10 #include "clang/AST/ASTContext.h" 11 #include "clang/ASTMatchers/ASTMatchFinder.h" 12 #include "clang/Tooling/FixIt.h" 13 #include "llvm/ADT/STLExtras.h" 14 #include "llvm/ADT/SmallVector.h" 24 using BasesVector = llvm::SmallVector<const CXXRecordDecl *, 5>;
27 const CXXRecordDecl &ThisClass) {
28 if (Parent.getCanonicalDecl() == ThisClass.getCanonicalDecl())
30 const CXXRecordDecl *ParentCanonicalDecl = Parent.getCanonicalDecl();
31 return ThisClass.bases_end() !=
32 llvm::find_if(ThisClass.bases(), [=](
const CXXBaseSpecifier &
Base) {
33 auto *BaseDecl =
Base.getType()->getAsCXXRecordDecl();
35 return ParentCanonicalDecl == BaseDecl->getCanonicalDecl();
40 const CXXRecordDecl &ThisClass,
41 const CXXMethodDecl &MemberDecl) {
43 for (
const auto &
Base : ThisClass.bases()) {
44 const auto *BaseDecl =
Base.getType()->getAsCXXRecordDecl();
45 const CXXMethodDecl *ActualMemberDecl =
46 MemberDecl.getCorrespondingMethodInClass(BaseDecl);
47 if (!ActualMemberDecl)
52 const Type *TypePtr = ActualMemberDecl->getThisType().getTypePtr();
53 const CXXRecordDecl *RecordDeclType = TypePtr->getPointeeCXXRecordDecl();
54 assert(RecordDeclType &&
"TypePtr is not a pointer to CXXRecordDecl!");
55 if (RecordDeclType->getCanonicalDecl()->isDerivedFrom(&GrandParent))
56 Result.emplace_back(RecordDeclType);
64 llvm::raw_string_ostream OS(QualName);
65 PrintingPolicy
PP(Decl->getASTContext().getPrintingPolicy());
66 PP.SuppressUnwrittenScope =
true;
67 Decl->printQualifiedName(OS,
PP);
74 clang::ASTContext &AC) {
75 std::string
Text = tooling::fixit::getText(E, AC).str();
79 [](
char C) {
return std::isspace(static_cast<unsigned char>(C)); }),
84 void ParentVirtualCallCheck::registerMatchers(MatchFinder *Finder) {
87 callee(memberExpr(hasDescendant(implicitCastExpr(
88 hasImplicitDestinationType(pointsTo(
89 type(anything()).bind(
"castToType"))),
90 hasSourceExpression(cxxThisExpr(hasType(
91 type(anything()).bind(
"thisType")))))))
93 callee(cxxMethodDecl(isVirtual()))),
97 void ParentVirtualCallCheck::check(
const MatchFinder::MatchResult &Result) {
98 const auto *Member = Result.Nodes.getNodeAs<MemberExpr>(
"member");
101 if (!Member->getQualifier())
104 const auto *MemberDecl = cast<CXXMethodDecl>(Member->getMemberDecl());
106 const auto *ThisTypePtr = Result.Nodes.getNodeAs<PointerType>(
"thisType");
109 const auto *ThisType = ThisTypePtr->getPointeeCXXRecordDecl();
112 const auto *CastToTypePtr = Result.Nodes.getNodeAs<
Type>(
"castToType");
113 assert(CastToTypePtr);
115 const auto *CastToType = CastToTypePtr->getAsCXXRecordDecl();
127 std::string ParentsStr;
128 ParentsStr.reserve(30 * Parents.size());
129 for (
const CXXRecordDecl *
Parent : Parents) {
130 if (!ParentsStr.empty())
131 ParentsStr.append(
" or ");
135 assert(Member->getQualifierLoc().getSourceRange().getBegin().isValid());
136 auto Diag = diag(Member->getQualifierLoc().getSourceRange().getBegin(),
137 "qualified name '%0' refers to a member overridden " 138 "in subclass%1; did you mean %2?")
140 << (Parents.size() > 1 ?
"es" :
"") << ParentsStr;
143 if (Parents.size() == 1 &&
145 !isa<ClassTemplateSpecializationDecl>(Parents.front()))
146 Diag << FixItHint::CreateReplacement(
147 Member->getQualifierLoc().getSourceRange(),
const FunctionDecl * Decl
static bool isParentOf(const CXXRecordDecl &Parent, const CXXRecordDecl &ThisClass)
llvm::SmallVector< const CXXRecordDecl *, 5 > BasesVector
static std::string getExprAsString(const clang::Expr &E, clang::ASTContext &AC)
static std::string getNameAsString(const NamedDecl *Decl)
static BasesVector getParentsByGrandParent(const CXXRecordDecl &GrandParent, const CXXRecordDecl &ThisClass, const CXXMethodDecl &MemberDecl)
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
std::unique_ptr< GlobalCompilationDatabase > Base