10 #include "clang/Frontend/CompilerInstance.h" 11 #include "clang/Lex/Lexer.h" 22 bool protoTypeHasNoParms(QualType QT) {
23 if (
auto PT = QT->getAs<PointerType>()) {
24 QT = PT->getPointeeType();
26 if (
auto *MPT = QT->getAs<MemberPointerType>()) {
27 QT = MPT->getPointeeType();
29 if (
auto FP = QT->getAs<FunctionProtoType>()) {
30 return FP->getNumParams() == 0;
35 const char FunctionId[] =
"function";
36 const char TypedefId[] =
"typedef";
38 const char VarId[] =
"var";
39 const char NamedCastId[] =
"named-cast";
40 const char CStyleCastId[] =
"c-style-cast";
41 const char ExplicitCastId[] =
"explicit-cast";
42 const char LambdaId[] =
"lambda";
46 void RedundantVoidArgCheck::registerMatchers(MatchFinder *Finder) {
47 if (!getLangOpts().CPlusPlus)
50 Finder->addMatcher(functionDecl(parameterCountIs(0), unless(isImplicit()),
51 unless(isInstantiated()), unless(isExternC()))
54 Finder->addMatcher(typedefNameDecl().bind(TypedefId),
this);
55 auto ParenFunctionType = parenType(innerType(functionType()));
56 auto PointerToFunctionType = pointee(ParenFunctionType);
57 auto FunctionOrMemberPointer =
58 anyOf(hasType(pointerType(PointerToFunctionType)),
59 hasType(memberPointerType(PointerToFunctionType)));
60 Finder->addMatcher(fieldDecl(FunctionOrMemberPointer).bind(
FieldId),
this);
61 Finder->addMatcher(varDecl(FunctionOrMemberPointer).bind(VarId),
this);
62 auto CastDestinationIsFunction =
63 hasDestinationType(pointsTo(ParenFunctionType));
65 cStyleCastExpr(CastDestinationIsFunction).bind(CStyleCastId),
this);
67 cxxStaticCastExpr(CastDestinationIsFunction).bind(NamedCastId),
this);
69 cxxReinterpretCastExpr(CastDestinationIsFunction).bind(NamedCastId),
72 cxxConstCastExpr(CastDestinationIsFunction).bind(NamedCastId),
this);
73 Finder->addMatcher(lambdaExpr().bind(LambdaId),
this);
76 void RedundantVoidArgCheck::check(
const MatchFinder::MatchResult &Result) {
77 const BoundNodes &Nodes = Result.Nodes;
78 if (
const auto *Function = Nodes.getNodeAs<FunctionDecl>(FunctionId)) {
79 processFunctionDecl(Result, Function);
80 }
else if (
const auto *TypedefName =
81 Nodes.getNodeAs<TypedefNameDecl>(TypedefId)) {
82 processTypedefNameDecl(Result, TypedefName);
83 }
else if (
const auto *Member = Nodes.getNodeAs<FieldDecl>(
FieldId)) {
84 processFieldDecl(Result, Member);
85 }
else if (
const auto *Var = Nodes.getNodeAs<VarDecl>(VarId)) {
86 processVarDecl(Result, Var);
87 }
else if (
const auto *NamedCast =
88 Nodes.getNodeAs<CXXNamedCastExpr>(NamedCastId)) {
89 processNamedCastExpr(Result, NamedCast);
90 }
else if (
const auto *CStyleCast =
91 Nodes.getNodeAs<CStyleCastExpr>(CStyleCastId)) {
92 processExplicitCastExpr(Result, CStyleCast);
93 }
else if (
const auto *ExplicitCast =
94 Nodes.getNodeAs<ExplicitCastExpr>(ExplicitCastId)) {
95 processExplicitCastExpr(Result, ExplicitCast);
96 }
else if (
const auto *Lambda = Nodes.getNodeAs<LambdaExpr>(LambdaId)) {
97 processLambdaExpr(Result, Lambda);
101 void RedundantVoidArgCheck::processFunctionDecl(
102 const MatchFinder::MatchResult &Result,
const FunctionDecl *Function) {
103 if (Function->isThisDeclarationADefinition()) {
104 SourceLocation Start = Function->getBeginLoc();
105 SourceLocation End = Function->getEndLoc();
106 if (
const Stmt *Body = Function->getBody()) {
107 End = Body->getBeginLoc();
108 if (End.isMacroID() &&
109 Result.SourceManager->isAtStartOfImmediateMacroExpansion(End))
110 End = Result.SourceManager->getExpansionLoc(End);
111 End = End.getLocWithOffset(-1);
113 removeVoidArgumentTokens(Result, SourceRange(Start, End),
114 "function definition");
116 removeVoidArgumentTokens(Result, Function->getSourceRange(),
117 "function declaration");
121 void RedundantVoidArgCheck::removeVoidArgumentTokens(
122 const ast_matchers::MatchFinder::MatchResult &Result, SourceRange
Range,
123 StringRef GrammarLocation) {
124 CharSourceRange CharRange =
126 *Result.SourceManager, getLangOpts());
128 std::string DeclText =
129 Lexer::getSourceText(CharRange, *Result.SourceManager, getLangOpts())
131 Lexer PrototypeLexer(CharRange.getBegin(), getLangOpts(), DeclText.data(),
132 DeclText.data(), DeclText.data() + DeclText.size());
138 TokenState State = NothingYet;
141 std::string Diagnostic =
142 (
"redundant void argument list in " + GrammarLocation).str();
144 while (!PrototypeLexer.LexFromRawLexer(ProtoToken)) {
147 if (ProtoToken.is(tok::TokenKind::l_paren)) {
148 State = SawLeftParen;
152 if (ProtoToken.is(tok::TokenKind::raw_identifier) &&
153 ProtoToken.getRawIdentifier() ==
"void") {
155 VoidToken = ProtoToken;
156 }
else if (ProtoToken.is(tok::TokenKind::l_paren)) {
157 State = SawLeftParen;
164 if (ProtoToken.is(tok::TokenKind::r_paren)) {
165 removeVoidToken(VoidToken, Diagnostic);
166 }
else if (ProtoToken.is(tok::TokenKind::l_paren)) {
167 State = SawLeftParen;
173 if (State == SawVoid && ProtoToken.is(tok::TokenKind::r_paren)) {
174 removeVoidToken(VoidToken, Diagnostic);
178 void RedundantVoidArgCheck::removeVoidToken(Token VoidToken,
179 StringRef Diagnostic) {
180 SourceLocation VoidLoc = VoidToken.getLocation();
181 diag(VoidLoc, Diagnostic) << FixItHint::CreateRemoval(VoidLoc);
184 void RedundantVoidArgCheck::processTypedefNameDecl(
185 const MatchFinder::MatchResult &Result,
186 const TypedefNameDecl *TypedefName) {
187 if (protoTypeHasNoParms(TypedefName->getUnderlyingType())) {
188 removeVoidArgumentTokens(Result, TypedefName->getSourceRange(),
189 isa<TypedefDecl>(TypedefName) ?
"typedef" 194 void RedundantVoidArgCheck::processFieldDecl(
195 const MatchFinder::MatchResult &Result,
const FieldDecl *Member) {
196 if (protoTypeHasNoParms(Member->getType())) {
197 removeVoidArgumentTokens(Result, Member->getSourceRange(),
198 "field declaration");
202 void RedundantVoidArgCheck::processVarDecl(
203 const MatchFinder::MatchResult &Result,
const VarDecl *Var) {
204 if (protoTypeHasNoParms(Var->getType())) {
205 SourceLocation Begin = Var->getBeginLoc();
206 if (Var->hasInit()) {
207 SourceLocation InitStart =
208 Result.SourceManager->getExpansionLoc(Var->getInit()->getBeginLoc())
209 .getLocWithOffset(-1);
210 removeVoidArgumentTokens(Result, SourceRange(Begin, InitStart),
211 "variable declaration with initializer");
213 removeVoidArgumentTokens(Result, Var->getSourceRange(),
214 "variable declaration");
219 void RedundantVoidArgCheck::processNamedCastExpr(
220 const MatchFinder::MatchResult &Result,
const CXXNamedCastExpr *NamedCast) {
221 if (protoTypeHasNoParms(NamedCast->getTypeAsWritten())) {
222 removeVoidArgumentTokens(
224 NamedCast->getTypeInfoAsWritten()->getTypeLoc().getSourceRange(),
229 void RedundantVoidArgCheck::processExplicitCastExpr(
230 const MatchFinder::MatchResult &Result,
231 const ExplicitCastExpr *ExplicitCast) {
232 if (protoTypeHasNoParms(ExplicitCast->getTypeAsWritten())) {
233 removeVoidArgumentTokens(Result, ExplicitCast->getSourceRange(),
238 void RedundantVoidArgCheck::processLambdaExpr(
239 const MatchFinder::MatchResult &Result,
const LambdaExpr *Lambda) {
240 if (Lambda->getLambdaClass()->getLambdaCallOperator()->getNumParams() == 0 &&
241 Lambda->hasExplicitParameters()) {
242 SourceManager *SM = Result.SourceManager;
243 TypeLoc TL = Lambda->getLambdaClass()->getLambdaTypeInfo()->getTypeLoc();
244 removeVoidArgumentTokens(Result,
245 {SM->getSpellingLoc(TL.getBeginLoc()),
246 SM->getSpellingLoc(TL.getEndLoc())},
247 "lambda expression");
llvm::Optional< Range > getTokenRange(const SourceManager &SM, const LangOptions &LangOpts, SourceLocation TokLoc)
Returns the taken range at TokLoc.
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
CharSourceRange Range
SourceRange for the file name.