11 #include "../utils/OptionsUtils.h"
12 #include "clang/AST/ASTContext.h"
13 #include "clang/ASTMatchers/ASTMatchFinder.h"
14 #include "llvm/ADT/Optional.h"
15 #include "llvm/Support/raw_ostream.h"
17 using namespace clang::ast_matchers;
21 namespace performance {
25 llvm::Optional<std::string> MakeCharacterLiteral(
const StringLiteral *Literal) {
28 llvm::raw_string_ostream OS(Result);
29 Literal->outputString(OS);
32 auto pos = Result.find_first_of(
'"');
33 if (pos == Result.npos)
36 pos = Result.find_last_of(
'"');
37 if (pos == Result.npos)
45 return hasType(qualType(anyOf(substTemplateTypeParmType(),
46 hasDescendant(substTemplateTypeParmType()))));
51 FasterStringFindCheck::FasterStringFindCheck(StringRef
Name,
55 Options.get(
"StringLikeClasses",
"std::basic_string"))) {}
66 const auto SingleChar =
67 expr(ignoringParenCasts(stringLiteral(hasSize(1)).bind(
"literal")));
68 const auto StringFindFunctions =
69 hasAnyName(
"find",
"rfind",
"find_first_of",
"find_first_not_of",
70 "find_last_of",
"find_last_not_of");
74 callee(functionDecl(StringFindFunctions).bind(
"func")),
75 anyOf(argumentCountIs(1), argumentCountIs(2)),
76 hasArgument(0, SingleChar),
77 on(expr(hasType(recordDecl(hasAnyName(SmallVector<StringRef, 4>(
78 StringLikeClasses.begin(), StringLikeClasses.end())))),
79 unless(hasSubstitutedType())))),
84 const auto *Literal = Result.Nodes.getNodeAs<StringLiteral>(
"literal");
85 const auto *FindFunc = Result.Nodes.getNodeAs<FunctionDecl>(
"func");
87 auto Replacement = MakeCharacterLiteral(Literal);
91 diag(Literal->getLocStart(),
"%0 called with a string literal consisting of "
92 "a single character; consider using the more "
93 "effective overload accepting a character")
94 << FindFunc << FixItHint::CreateReplacement(
95 CharSourceRange::getTokenRange(Literal->getLocStart(),
96 Literal->getLocEnd()),
LangOptions getLangOpts() const
Returns the language options from the context.
std::string serializeStringList(ArrayRef< std::string > Strings)
Serialize a sequence of names that can be parsed by parseStringList.
std::unique_ptr< ast_matchers::MatchFinder > Finder
Base class for all clang-tidy checks.
std::vector< std::string > parseStringList(StringRef Option)
Parse a semicolon separated list of strings.
AST_MATCHER_FUNCTION(ast_matchers::TypeMatcher, isReferenceToConst)
void store(ClangTidyOptions::OptionMap &Options, StringRef LocalName, StringRef Value) const
Stores an option with the check-local name LocalName with string value Value to Options.
std::map< std::string, std::string > OptionMap
ClangTidyContext & Context
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.
DiagnosticBuilder diag(SourceLocation Loc, StringRef Description, DiagnosticIDs::Level Level=DiagnosticIDs::Warning)
Add a diagnostic with the check's name.