11 #include "../utils/Matchers.h"
12 #include "../utils/OptionsUtils.h"
13 #include "clang/AST/ASTContext.h"
14 #include "clang/ASTMatchers/ASTMatchFinder.h"
16 using namespace clang::ast_matchers;
17 using namespace clang::tidy::matchers;
25 ast_matchers::internal::BindableMatcher<Stmt>
26 handleFrom(
const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle,
27 const ast_matchers::internal::Matcher<Expr> &Arg) {
28 return cxxConstructExpr(hasDeclaration(cxxMethodDecl(ofClass(IsAHandle))),
32 ast_matchers::internal::Matcher<Stmt> handleFromTemporaryValue(
33 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
37 const auto TemporaryTernary =
38 conditionalOperator(hasTrueExpression(cxxBindTemporaryExpr()),
39 hasFalseExpression(cxxBindTemporaryExpr()));
41 return handleFrom(IsAHandle, anyOf(cxxBindTemporaryExpr(), TemporaryTernary));
44 ast_matchers::internal::Matcher<RecordDecl> isASequence() {
45 return hasAnyName(
"::std::deque",
"::std::forward_list",
"::std::list",
49 ast_matchers::internal::Matcher<RecordDecl> isASet() {
50 return hasAnyName(
"::std::set",
"::std::multiset",
"::std::unordered_set",
51 "::std::unordered_multiset");
54 ast_matchers::internal::Matcher<RecordDecl> isAMap() {
55 return hasAnyName(
"::std::map",
"::std::multimap",
"::std::unordered_map",
56 "::std::unordered_multimap");
59 ast_matchers::internal::BindableMatcher<Stmt> makeContainerMatcher(
60 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
69 ignoringParenImpCasts(handleFromTemporaryValue(IsAHandle))),
73 callee(functionDecl(hasAnyName(
"assign",
"push_back",
"resize"))),
74 on(expr(hasType(recordDecl(isASequence()))))),
77 callee(functionDecl(hasName(
"insert"))),
78 on(expr(hasType(recordDecl(anyOf(isASequence(), isASet())))))),
80 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(isAMap()))),
81 hasOverloadedOperatorName(
"[]"))));
86 DanglingHandleCheck::DanglingHandleCheck(StringRef
Name,
91 "std::basic_string_view;std::experimental::basic_string_view"))),
92 IsAHandle(cxxRecordDecl(hasAnyName(std::vector<StringRef>(
93 HandleClasses.begin(), HandleClasses.end())))
101 void DanglingHandleCheck::registerMatchersForVariables(MatchFinder *
Finder) {
102 const auto ConvertedHandle = handleFromTemporaryValue(IsAHandle);
106 varDecl(hasType(cxxRecordDecl(IsAHandle)),
108 exprWithCleanups(has(ignoringParenImpCasts(ConvertedHandle)))
115 hasType(cxxRecordDecl(IsAHandle)), unless(parmVarDecl()),
116 hasInitializer(exprWithCleanups(has(ignoringParenImpCasts(handleFrom(
117 IsAHandle, ConvertedHandle))))
122 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(IsAHandle))),
123 hasOverloadedOperatorName(
"="),
124 hasArgument(1, ConvertedHandle))
129 Finder->addMatcher(makeContainerMatcher(IsAHandle).bind(
"bad_stmt"),
this);
132 void DanglingHandleCheck::registerMatchersForReturn(MatchFinder *Finder) {
140 has(ignoringImplicit(handleFrom(
142 handleFrom(IsAHandle, declRefExpr(to(varDecl(
144 hasAutomaticStorageDuration(),
146 anyOf(hasType(arrayType()),
148 unless(IsAHandle))))))))))),
150 unless(hasAncestor(lambdaExpr())))
157 has(ignoringParenImpCasts(exprWithCleanups(has(ignoringParenImpCasts(
158 handleFrom(IsAHandle, handleFromTemporaryValue(IsAHandle))))))))
164 registerMatchersForVariables(Finder);
165 registerMatchersForReturn(Finder);
169 auto *Handle = Result.Nodes.getNodeAs<CXXRecordDecl>(
"handle");
170 diag(Result.Nodes.getNodeAs<Stmt>(
"bad_stmt")->getLocStart(),
171 "%0 outlives its value")
172 << Handle->getQualifiedNameAsString();
std::string serializeStringList(ArrayRef< std::string > Strings)
Serialize a sequence of names that can be parsed by parseStringList.
std::unique_ptr< ast_matchers::MatchFinder > Finder
Base class for all clang-tidy checks.
void registerMatchers(ast_matchers::MatchFinder *Finder) override
Override this to register AST matchers with Finder.
std::vector< std::string > parseStringList(StringRef Option)
Parse a semicolon separated list of strings.
void store(ClangTidyOptions::OptionMap &Options, StringRef LocalName, StringRef Value) const
Stores an option with the check-local name LocalName with string value Value to Options.
std::map< std::string, std::string > OptionMap
ClangTidyContext & Context
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.
void check(const ast_matchers::MatchFinder::MatchResult &Result) override
ClangTidyChecks that register ASTMatchers should do the actual work in here.
DiagnosticBuilder diag(SourceLocation Loc, StringRef Description, DiagnosticIDs::Level Level=DiagnosticIDs::Warning)
Add a diagnostic with the check's name.
void storeOptions(ClangTidyOptions::OptionMap &Opts) override
Should store all options supported by this check with their current values or default values for opti...