10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
12 #include "clang/Lex/Lexer.h"
22 return Node.getNumInits() == N;
27 switch (InitType->getScalarTypeKind()) {
28 case Type::STK_CPointer:
29 case Type::STK_BlockPointer:
30 case Type::STK_ObjCObjectPointer:
31 case Type::STK_MemberPointer:
37 case Type::STK_Integral:
38 switch (InitType->castAs<BuiltinType>()->getKind()) {
39 case BuiltinType::Char_U:
40 case BuiltinType::UChar:
41 case BuiltinType::Char_S:
42 case BuiltinType::SChar:
44 case BuiltinType::WChar_U:
45 case BuiltinType::WChar_S:
47 case BuiltinType::Char16:
49 case BuiltinType::Char32:
55 case Type::STK_Floating:
56 switch (InitType->castAs<BuiltinType>()->getKind()) {
57 case BuiltinType::Half:
58 case BuiltinType::Float:
64 case Type::STK_FloatingComplex:
65 case Type::STK_IntegralComplex:
67 InitType->castAs<ComplexType>()->getElementType());
69 case Type::STK_FixedPoint:
70 switch (InitType->castAs<BuiltinType>()->getKind()) {
71 case BuiltinType::ShortAccum:
72 case BuiltinType::SatShortAccum:
74 case BuiltinType::Accum:
75 case BuiltinType::SatAccum:
77 case BuiltinType::LongAccum:
78 case BuiltinType::SatLongAccum:
80 case BuiltinType::UShortAccum:
81 case BuiltinType::SatUShortAccum:
83 case BuiltinType::UAccum:
84 case BuiltinType::SatUAccum:
86 case BuiltinType::ULongAccum:
87 case BuiltinType::SatULongAccum:
89 case BuiltinType::ShortFract:
90 case BuiltinType::SatShortFract:
92 case BuiltinType::Fract:
93 case BuiltinType::SatFract:
95 case BuiltinType::LongFract:
96 case BuiltinType::SatLongFract:
98 case BuiltinType::UShortFract:
99 case BuiltinType::SatUShortFract:
101 case BuiltinType::UFract:
102 case BuiltinType::SatUFract:
104 case BuiltinType::ULongFract:
105 case BuiltinType::SatULongFract:
108 llvm_unreachable(
"Unhandled fixed point BuiltinType");
111 llvm_unreachable(
"Invalid scalar type kind");
115 switch (
E->getStmtClass()) {
116 case Stmt::CXXNullPtrLiteralExprClass:
117 case Stmt::ImplicitValueInitExprClass:
119 case Stmt::InitListExprClass:
120 return cast<InitListExpr>(
E)->getNumInits() == 0;
121 case Stmt::CharacterLiteralClass:
122 return !cast<CharacterLiteral>(
E)->getValue();
123 case Stmt::CXXBoolLiteralExprClass:
124 return !cast<CXXBoolLiteralExpr>(
E)->getValue();
125 case Stmt::IntegerLiteralClass:
126 return !cast<IntegerLiteral>(
E)->getValue();
127 case Stmt::FloatingLiteralClass: {
128 llvm::APFloat Value = cast<FloatingLiteral>(
E)->getValue();
129 return Value.isZero() && !Value.isNegative();
137 auto *UnaryOp = dyn_cast<UnaryOperator>(
E);
138 if (UnaryOp && UnaryOp->getOpcode() == UO_Plus)
139 return UnaryOp->getSubExpr();
144 auto *InitList = dyn_cast<InitListExpr>(
E);
145 if (InitList && InitList->getNumInits() == 1)
146 return InitList->getInit(0)->IgnoreParenImpCasts();
157 if (E1->getStmtClass() != E2->getStmtClass())
160 switch (E1->getStmtClass()) {
161 case Stmt::UnaryOperatorClass:
162 return sameValue(cast<UnaryOperator>(E1)->getSubExpr(),
163 cast<UnaryOperator>(E2)->getSubExpr());
164 case Stmt::CharacterLiteralClass:
165 return cast<CharacterLiteral>(E1)->getValue() ==
166 cast<CharacterLiteral>(E2)->getValue();
167 case Stmt::CXXBoolLiteralExprClass:
168 return cast<CXXBoolLiteralExpr>(E1)->getValue() ==
169 cast<CXXBoolLiteralExpr>(E2)->getValue();
170 case Stmt::IntegerLiteralClass:
171 return cast<IntegerLiteral>(E1)->getValue() ==
172 cast<IntegerLiteral>(E2)->getValue();
173 case Stmt::FloatingLiteralClass:
174 return cast<FloatingLiteral>(E1)->getValue().bitwiseIsEqual(
175 cast<FloatingLiteral>(E2)->getValue());
176 case Stmt::StringLiteralClass:
177 return cast<StringLiteral>(E1)->getString() ==
178 cast<StringLiteral>(E2)->getString();
179 case Stmt::DeclRefExprClass:
180 return cast<DeclRefExpr>(E1)->getDecl() == cast<DeclRefExpr>(E2)->getDecl();
186 UseDefaultMemberInitCheck::UseDefaultMemberInitCheck(StringRef
Name,
189 UseAssignment(Options.get(
"UseAssignment", false)),
190 IgnoreMacros(Options.getLocalOrGlobal(
"IgnoreMacros", true)) {}
200 anyOf(stringLiteral(), characterLiteral(), integerLiteral(),
201 unaryOperator(hasAnyOperatorName(
"+",
"-"),
202 hasUnaryOperand(integerLiteral())),
204 unaryOperator(hasAnyOperatorName(
"+",
"-"),
205 hasUnaryOperand(floatLiteral())),
206 cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(),
207 declRefExpr(to(enumConstantDecl())));
210 anyOf(initListExpr(anyOf(
211 allOf(initCountIs(1), hasInit(0, ignoringImplicit(InitBase))),
217 isDefaultConstructor(), unless(isInstantiated()),
218 forEachConstructorInitializer(
223 hasInClassInitializer(anything()),
224 hasParent(recordDecl(isUnion()))))),
225 isWritten(), withInitializer(ignoringImplicit(Init)))
231 unless(ast_matchers::isTemplateInstantiation()),
232 forEachConstructorInitializer(
233 cxxCtorInitializer(forField(hasInClassInitializer(anything())),
235 withInitializer(ignoringImplicit(Init)))
241 if (
const auto *Default =
242 Result.Nodes.getNodeAs<CXXCtorInitializer>(
"default"))
243 checkDefaultInit(Result, Default);
244 else if (
const auto *Existing =
245 Result.Nodes.getNodeAs<CXXCtorInitializer>(
"existing"))
246 checkExistingInit(Result, Existing);
248 llvm_unreachable(
"Bad Callback. No node provided.");
251 void UseDefaultMemberInitCheck::checkDefaultInit(
252 const MatchFinder::MatchResult &Result,
const CXXCtorInitializer *Init) {
253 const FieldDecl *Field = Init->getAnyMember();
255 SourceLocation StartLoc = Field->getBeginLoc();
256 if (StartLoc.isMacroID() && IgnoreMacros)
259 SourceLocation FieldEnd =
260 Lexer::getLocForEndOfToken(Field->getSourceRange().getEnd(), 0,
262 SourceLocation LParenEnd = Lexer::getLocForEndOfToken(
263 Init->getLParenLoc(), 0, *Result.SourceManager,
getLangOpts());
264 CharSourceRange InitRange =
265 CharSourceRange::getCharRange(LParenEnd, Init->getRParenLoc());
267 bool ValueInit = isa<ImplicitValueInitExpr>(Init->getInit());
268 bool CanAssign = UseAssignment && (!ValueInit || !Init->getInit()->getType()->isEnumeralType());
271 diag(Field->getLocation(),
"use default member initializer for %0")
273 << FixItHint::CreateInsertion(FieldEnd, CanAssign ?
" = " :
"{")
274 << FixItHint::CreateInsertionFromRange(FieldEnd, InitRange);
276 if (CanAssign && ValueInit)
277 Diag << FixItHint::CreateInsertion(
281 Diag << FixItHint::CreateInsertion(FieldEnd,
"}");
283 Diag << FixItHint::CreateRemoval(Init->getSourceRange());
286 void UseDefaultMemberInitCheck::checkExistingInit(
287 const MatchFinder::MatchResult &Result,
const CXXCtorInitializer *Init) {
288 const FieldDecl *Field = Init->getAnyMember();
290 if (!
sameValue(Field->getInClassInitializer(), Init->getInit()))
293 diag(Init->getSourceLocation(),
"member initializer for %0 is redundant")
295 << FixItHint::CreateRemoval(Init->getSourceRange());