10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
22 HeaderFileExtensions) {
24 Node.getBeginLoc(), Finder->getASTContext().getSourceManager(),
25 HeaderFileExtensions);
30 DefinitionsInHeadersCheck::DefinitionsInHeadersCheck(StringRef
Name,
33 UseHeaderFileExtension(Options.get(
"UseHeaderFileExtension", true)),
34 RawStringHeaderFileExtensions(Options.getLocalOrGlobal(
41 llvm::errs() <<
"Invalid header file extension: "
42 << RawStringHeaderFileExtensions <<
"\n";
48 Options.
store(Opts,
"UseHeaderFileExtension", UseHeaderFileExtension);
49 Options.
store(Opts,
"HeaderFileExtensions", RawStringHeaderFileExtensions);
53 auto DefinitionMatcher =
54 anyOf(functionDecl(isDefinition(), unless(isDeleted())),
55 varDecl(isDefinition()));
56 if (UseHeaderFileExtension) {
57 Finder->addMatcher(namedDecl(DefinitionMatcher,
58 usesHeaderFileExtension(HeaderFileExtensions))
63 namedDecl(DefinitionMatcher,
64 anyOf(usesHeaderFileExtension(HeaderFileExtensions),
65 unless(isExpansionInMainFile())))
73 if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred())
84 const auto *ND = Result.Nodes.getNodeAs<NamedDecl>(
"name-decl");
86 if (ND->isInvalidDecl())
98 if (!ND->hasExternalFormalLinkage() && !ND->isInAnonymousNamespace())
101 if (
const auto *FD = dyn_cast<FunctionDecl>(ND)) {
106 if (FD->getTemplatedKind() == FunctionDecl::TK_FunctionTemplate)
109 if (FD->isTemplateInstantiation())
113 if (
const auto *
MD = dyn_cast<CXXMethodDecl>(FD)) {
114 const auto *DC =
MD->getDeclContext();
115 while (DC->isRecord()) {
116 if (
const auto *RD = dyn_cast<CXXRecordDecl>(DC)) {
117 if (isa<ClassTemplatePartialSpecializationDecl>(RD))
119 if (RD->getDescribedClassTemplate())
122 DC = DC->getParent();
126 bool IsFullSpec = FD->getTemplateSpecializationKind() != TSK_Undeclared;
127 diag(FD->getLocation(),
128 "%select{function|full function template specialization}0 %1 defined "
129 "in a header file; function definitions in header files can lead to "
132 diag(FD->getLocation(),
"make as 'inline'",
134 << FixItHint::CreateInsertion(FD->getInnerLocStart(),
"inline ");
135 }
else if (
const auto *VD = dyn_cast<VarDecl>(ND)) {
137 if (VD->getDescribedVarTemplate())
140 if (VD->getDeclContext()->isDependentContext() && VD->isStaticDataMember())
143 if (isTemplateInstantiation(VD->getTemplateSpecializationKind()))
146 if (VD->hasLocalStorage() || VD->isStaticLocal())
152 diag(VD->getLocation(),
153 "variable %0 defined in a header file; "
154 "variable definitions in header files can lead to ODR violations")