11 #include "../utils/OptionsUtils.h"
12 #include "clang/AST/ASTContext.h"
13 #include "clang/ASTMatchers/ASTMatchFinder.h"
14 #include "clang/Basic/CharInfo.h"
15 #include "llvm/ADT/STLExtras.h"
16 #include "llvm/ADT/StringExtras.h"
17 #include "llvm/Support/Regex.h"
41 FixItHint generateFixItHint(
const ObjCPropertyDecl *
Decl, NamingStyle Style) {
43 auto NewName =
Decl->getName().str();
45 if (Style == CategoryProperty) {
51 if (NewName !=
Name) {
52 return FixItHint::CreateReplacement(
53 CharSourceRange::getTokenRange(SourceRange(
Decl->getLocation())),
54 llvm::StringRef(NewName));
60 std::string validPropertyNameRegex(
bool UsedInMatcher) {
78 std::string StartMatcher = UsedInMatcher ?
"::" :
"^";
79 return StartMatcher +
"([a-z]|[A-Z][A-Z0-9])[a-z0-9A-Z]*$";
82 bool hasCategoryPropertyPrefix(llvm::StringRef PropertyName) {
84 llvm::Regex(
"^[a-zA-Z][a-zA-Z0-9]*_[a-zA-Z0-9][a-zA-Z0-9_]+$");
85 return RegexExp.match(PropertyName);
88 bool prefixedPropertyNameValid(llvm::StringRef PropertyName) {
89 size_t Start = PropertyName.find_first_of(
'_');
90 assert(Start != llvm::StringRef::npos && Start + 1 < PropertyName.size());
91 auto Prefix = PropertyName.substr(0, Start);
92 if (Prefix.lower() != Prefix) {
95 auto RegexExp = llvm::Regex(llvm::StringRef(validPropertyNameRegex(
false)));
96 return RegexExp.match(PropertyName.substr(Start + 1));
100 void PropertyDeclarationCheck::registerMatchers(MatchFinder *Finder) {
101 Finder->addMatcher(objcPropertyDecl(
104 unless(matchesName(validPropertyNameRegex(
true))))
109 void PropertyDeclarationCheck::check(
const MatchFinder::MatchResult &Result) {
110 const auto *MatchedDecl =
111 Result.Nodes.getNodeAs<ObjCPropertyDecl>(
"property");
112 assert(MatchedDecl->getName().size() > 0);
113 auto *DeclContext = MatchedDecl->getDeclContext();
114 auto *CategoryDecl = llvm::dyn_cast<ObjCCategoryDecl>(DeclContext);
116 if (CategoryDecl !=
nullptr &&
117 hasCategoryPropertyPrefix(MatchedDecl->getName())) {
118 if (!prefixedPropertyNameValid(MatchedDecl->getName()) ||
119 CategoryDecl->IsClassExtension()) {
120 NamingStyle Style = CategoryDecl->IsClassExtension() ? StandardProperty
122 diag(MatchedDecl->getLocation(),
123 "property name '%0' not using lowerCamelCase style or not prefixed "
124 "in a category, according to the Apple Coding Guidelines")
125 << MatchedDecl->getName() << generateFixItHint(MatchedDecl, Style);
129 diag(MatchedDecl->getLocation(),
130 "property name '%0' not using lowerCamelCase style or not prefixed in "
131 "a category, according to the Apple Coding Guidelines")
132 << MatchedDecl->getName()
133 << generateFixItHint(MatchedDecl, StandardProperty);