10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
12 #include "clang/Lex/Lexer.h"
13 #include "clang/Tooling/FixIt.h"
19 namespace readability {
21 void MisplacedArrayIndexCheck::registerMatchers(MatchFinder *Finder) {
23 traverse(ast_type_traits::TK_AsIs,
24 arraySubscriptExpr(hasLHS(hasType(isInteger())),
25 hasRHS(hasType(isAnyPointer())))
30 void MisplacedArrayIndexCheck::check(
const MatchFinder::MatchResult &Result) {
31 const auto *ArraySubscriptE =
32 Result.Nodes.getNodeAs<ArraySubscriptExpr>(
"expr");
34 auto Diag = diag(ArraySubscriptE->getBeginLoc(),
"confusing array subscript "
35 "expression, usually the "
36 "index is inside the []");
40 const Expr *RHSE = ArraySubscriptE->getRHS()->IgnoreParenImpCasts();
41 if (!isa<StringLiteral>(RHSE) && !isa<DeclRefExpr>(RHSE) &&
42 !isa<MemberExpr>(RHSE))
45 const StringRef LText = tooling::fixit::getText(
46 ArraySubscriptE->getLHS()->getSourceRange(), *Result.Context);
47 const StringRef RText = tooling::fixit::getText(
48 ArraySubscriptE->getRHS()->getSourceRange(), *Result.Context);
50 Diag << FixItHint::CreateReplacement(
51 ArraySubscriptE->getLHS()->getSourceRange(), RText);
52 Diag << FixItHint::CreateReplacement(
53 ArraySubscriptE->getRHS()->getSourceRange(), LText);