10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
12 #include "clang/Lex/Lexer.h"
13 #include "clang/Tooling/FixIt.h"
21 void ReturnBracedInitListCheck::registerMatchers(MatchFinder *Finder) {
25 unless(anyOf(hasDeclaration(cxxConstructorDecl(isExplicit())),
26 isListInitialization(), hasDescendant(initListExpr()),
27 isInTemplateInstantiation())))
30 auto CtorAsArgument = materializeTemporaryExpr(anyOf(
31 has(ConstructExpr), has(cxxFunctionalCastExpr(has(ConstructExpr)))));
34 traverse(ast_type_traits::TK_AsIs,
37 returns(unless(anyOf(builtinType(), autoType()))),
38 hasDescendant(returnStmt(hasReturnValue(
39 has(cxxConstructExpr(has(CtorAsArgument)))))))
44 void ReturnBracedInitListCheck::check(
const MatchFinder::MatchResult &Result) {
45 const auto *MatchedFunctionDecl = Result.Nodes.getNodeAs<FunctionDecl>(
"fn");
46 const auto *MatchedConstructExpr =
47 Result.Nodes.getNodeAs<CXXConstructExpr>(
"ctor");
50 SourceLocation
Loc = MatchedConstructExpr->getExprLoc();
56 MatchedFunctionDecl->getReturnType().getCanonicalType();
57 const QualType ConstructType =
58 MatchedConstructExpr->getType().getCanonicalType();
62 auto Diag = diag(
Loc,
"avoid repeating the return type from the "
63 "declaration; use a braced initializer list instead");
65 const SourceRange CallParensRange =
66 MatchedConstructExpr->getParenOrBraceRange();
69 if (CallParensRange.isInvalid())
73 for (
unsigned I = 0, NumParams = MatchedConstructExpr->getNumArgs();
75 if (
const auto *VD = dyn_cast<VarDecl>(
76 MatchedConstructExpr->getConstructor()->getParamDecl(I))) {
77 if (MatchedConstructExpr->getArg(I)->getType().getCanonicalType() !=
78 VD->getType().getCanonicalType())
84 CharSourceRange CtorCallSourceRange = CharSourceRange::getTokenRange(
85 Loc, CallParensRange.getBegin().getLocWithOffset(-1));
87 Diag << FixItHint::CreateRemoval(CtorCallSourceRange)
88 << FixItHint::CreateReplacement(CallParensRange.getBegin(),
"{")
89 << FixItHint::CreateReplacement(CallParensRange.getEnd(),
"}");