10 #include "../utils/LexerUtils.h"
11 #include "clang/AST/ASTContext.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
20 void SuspiciousSemicolonCheck::registerMatchers(MatchFinder *Finder) {
22 stmt(anyOf(ifStmt(hasThen(nullStmt().bind(
"semi")),
23 unless(hasElse(stmt())),
24 unless(isConstexpr())),
25 forStmt(hasBody(nullStmt().bind(
"semi"))),
26 cxxForRangeStmt(hasBody(nullStmt().bind(
"semi"))),
27 whileStmt(hasBody(nullStmt().bind(
"semi")))))
32 void SuspiciousSemicolonCheck::check(
const MatchFinder::MatchResult &Result) {
33 if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred())
36 const auto *Semicolon = Result.Nodes.getNodeAs<NullStmt>(
"semi");
37 SourceLocation LocStart = Semicolon->getBeginLoc();
39 if (LocStart.isMacroID())
42 ASTContext &Ctxt = *Result.Context;
45 auto &SM = *Result.SourceManager;
46 unsigned SemicolonLine = SM.getSpellingLineNumber(LocStart);
48 const auto *Statement = Result.Nodes.getNodeAs<Stmt>(
"stmt");
49 const bool IsIfStmt = isa<IfStmt>(Statement);
52 SM.getSpellingLineNumber(Token.getLocation()) != SemicolonLine)
55 SourceLocation LocEnd = Semicolon->getEndLoc();
56 FileID FID = SM.getFileID(LocEnd);
57 const llvm::MemoryBuffer *Buffer = SM.getBuffer(FID, LocEnd);
58 Lexer Lexer(SM.getLocForStartOfFile(FID), Ctxt.getLangOpts(),
59 Buffer->getBufferStart(), SM.getCharacterData(LocEnd) + 1,
60 Buffer->getBufferEnd());
61 if (Lexer.LexFromRawLexer(Token))
64 unsigned BaseIndent = SM.getSpellingColumnNumber(Statement->getBeginLoc());
65 unsigned NewTokenIndent = SM.getSpellingColumnNumber(Token.getLocation());
66 unsigned NewTokenLine = SM.getSpellingLineNumber(Token.getLocation());
68 if (!IsIfStmt && NewTokenIndent <= BaseIndent &&
69 Token.getKind() != tok::l_brace && NewTokenLine != SemicolonLine)
72 diag(LocStart,
"potentially unintended semicolon")
73 << FixItHint::CreateRemoval(SourceRange(LocStart, LocEnd));