10 #include "../utils/Matchers.h"
11 #include "../utils/OptionsUtils.h"
12 #include "clang/AST/ASTContext.h"
13 #include "clang/ASTMatchers/ASTMatchFinder.h"
24 ast_matchers::internal::BindableMatcher<Stmt>
25 handleFrom(
const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle,
26 const ast_matchers::internal::Matcher<Expr> &Arg) {
28 anyOf(cxxConstructExpr(hasDeclaration(cxxMethodDecl(ofClass(IsAHandle))),
30 cxxMemberCallExpr(hasType(cxxRecordDecl(IsAHandle)),
31 callee(memberExpr(member(cxxConversionDecl()))),
35 ast_matchers::internal::Matcher<Stmt> handleFromTemporaryValue(
36 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
40 const auto TemporaryTernary =
41 conditionalOperator(hasTrueExpression(cxxBindTemporaryExpr()),
42 hasFalseExpression(cxxBindTemporaryExpr()));
44 return handleFrom(IsAHandle, anyOf(cxxBindTemporaryExpr(), TemporaryTernary));
47 ast_matchers::internal::Matcher<RecordDecl> isASequence() {
48 return hasAnyName(
"::std::deque",
"::std::forward_list",
"::std::list",
52 ast_matchers::internal::Matcher<RecordDecl> isASet() {
53 return hasAnyName(
"::std::set",
"::std::multiset",
"::std::unordered_set",
54 "::std::unordered_multiset");
57 ast_matchers::internal::Matcher<RecordDecl> isAMap() {
58 return hasAnyName(
"::std::map",
"::std::multimap",
"::std::unordered_map",
59 "::std::unordered_multimap");
62 ast_matchers::internal::BindableMatcher<Stmt> makeContainerMatcher(
63 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
72 ignoringParenImpCasts(handleFromTemporaryValue(IsAHandle))),
76 callee(functionDecl(hasAnyName(
"assign",
"push_back",
"resize"))),
77 on(expr(hasType(hasUnqualifiedDesugaredType(
78 recordType(hasDeclaration(recordDecl(isASequence())))))))),
80 cxxMemberCallExpr(callee(functionDecl(hasName(
"insert"))),
81 on(expr(hasType(hasUnqualifiedDesugaredType(
82 recordType(hasDeclaration(recordDecl(
83 anyOf(isASequence(), isASet()))))))))),
85 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(isAMap()))),
86 hasOverloadedOperatorName(
"[]"))));
91 DanglingHandleCheck::DanglingHandleCheck(StringRef
Name,
96 "std::basic_string_view;std::experimental::basic_string_view"))),
97 IsAHandle(cxxRecordDecl(hasAnyName(std::vector<StringRef>(
98 HandleClasses.begin(), HandleClasses.end())))
106 void DanglingHandleCheck::registerMatchersForVariables(MatchFinder *Finder) {
107 const auto ConvertedHandle = handleFromTemporaryValue(IsAHandle);
111 varDecl(hasType(hasUnqualifiedDesugaredType(
112 recordType(hasDeclaration(cxxRecordDecl(IsAHandle))))),
114 exprWithCleanups(has(ignoringParenImpCasts(ConvertedHandle)))
120 traverse(ast_type_traits::TK_AsIs,
121 varDecl(hasType(hasUnqualifiedDesugaredType(recordType(
122 hasDeclaration(cxxRecordDecl(IsAHandle))))),
123 unless(parmVarDecl()),
124 hasInitializer(exprWithCleanups(
125 has(ignoringParenImpCasts(handleFrom(
126 IsAHandle, ConvertedHandle))))
127 .bind(
"bad_stmt")))),
131 traverse(ast_type_traits::TK_AsIs,
132 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(IsAHandle))),
133 hasOverloadedOperatorName(
"="),
134 hasArgument(1, ConvertedHandle))
139 Finder->addMatcher(traverse(ast_type_traits::TK_AsIs,
140 makeContainerMatcher(IsAHandle).bind(
"bad_stmt")),
144 void DanglingHandleCheck::registerMatchersForReturn(MatchFinder *Finder) {
148 ast_type_traits::TK_AsIs,
154 has(ignoringImplicit(handleFrom(
156 handleFrom(IsAHandle,
157 declRefExpr(to(varDecl(
159 hasAutomaticStorageDuration(),
161 anyOf(hasType(arrayType()),
162 hasType(hasUnqualifiedDesugaredType(
163 recordType(hasDeclaration(recordDecl(
164 unless(IsAHandle)))))))))))))),
166 unless(hasAncestor(lambdaExpr())))
173 ast_type_traits::TK_AsIs,
174 returnStmt(has(exprWithCleanups(has(ignoringParenImpCasts(handleFrom(
175 IsAHandle, handleFromTemporaryValue(IsAHandle)))))))
181 registerMatchersForVariables(Finder);
182 registerMatchersForReturn(Finder);
186 auto *Handle = Result.Nodes.getNodeAs<CXXRecordDecl>(
"handle");
187 diag(Result.Nodes.getNodeAs<Stmt>(
"bad_stmt")->getBeginLoc(),
188 "%0 outlives its value")
189 << Handle->getQualifiedNameAsString();