10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
24 const Stmt *nextStmt(
const MatchFinder::MatchResult &Result,
const Stmt *S) {
25 auto Parents = Result.Context->getParents(*S);
31 const Stmt *Prev =
nullptr;
32 for (
const Stmt *Child :
Parent->children()) {
37 return nextStmt(Result,
Parent);
40 using ExpansionRanges = std::vector<SourceRange>;
45 ExpansionRanges getExpansionRanges(SourceLocation
Loc,
46 const MatchFinder::MatchResult &Result) {
48 while (
Loc.isMacroID()) {
50 Result.SourceManager->getImmediateExpansionRange(
Loc).getAsRange());
51 Loc = Locs.back().getBegin();
58 void MultipleStatementMacroCheck::registerMatchers(MatchFinder *Finder) {
59 const auto Inner = expr(
isInMacro(), unless(compoundStmt())).bind(
"inner");
61 stmt(anyOf(ifStmt(hasThen(
Inner)), ifStmt(hasElse(
Inner)).bind(
"else"),
62 whileStmt(hasBody(
Inner)), forStmt(hasBody(
Inner))))
67 void MultipleStatementMacroCheck::check(
68 const MatchFinder::MatchResult &Result) {
69 const auto *
Inner = Result.Nodes.getNodeAs<Expr>(
"inner");
70 const auto *
Outer = Result.Nodes.getNodeAs<Stmt>(
"outer");
71 const auto *Next = nextStmt(Result,
Outer);
75 SourceLocation OuterLoc =
Outer->getBeginLoc();
76 if (Result.Nodes.getNodeAs<Stmt>(
"else"))
77 OuterLoc = cast<IfStmt>(
Outer)->getElseLoc();
79 auto InnerRanges = getExpansionRanges(
Inner->getBeginLoc(), Result);
80 auto OuterRanges = getExpansionRanges(OuterLoc, Result);
81 auto NextRanges = getExpansionRanges(Next->getBeginLoc(), Result);
85 while (!InnerRanges.empty() && !OuterRanges.empty() && !NextRanges.empty() &&
86 InnerRanges.back() == OuterRanges.back() &&
87 InnerRanges.back() == NextRanges.back()) {
88 InnerRanges.pop_back();
89 OuterRanges.pop_back();
90 NextRanges.pop_back();
95 if (InnerRanges.empty() || NextRanges.empty() ||
96 InnerRanges.back() != NextRanges.back())
99 diag(InnerRanges.back().getBegin(),
"multiple statement macro used without "
100 "braces; some statements will be "
101 "unconditionally executed");