clang-tools  7.0.0
AndroidTidyModule.cpp
Go to the documentation of this file.
1 //===--- AndroidTidyModule.cpp - clang-tidy--------------------------------===//
2 //
3 // The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 
10 #include "../ClangTidy.h"
11 #include "../ClangTidyModule.h"
12 #include "../ClangTidyModuleRegistry.h"
13 #include "CloexecAccept4Check.h"
14 #include "CloexecAcceptCheck.h"
15 #include "CloexecCreatCheck.h"
16 #include "CloexecDupCheck.h"
19 #include "CloexecFopenCheck.h"
23 #include "CloexecOpenCheck.h"
24 #include "CloexecSocketCheck.h"
26 
27 using namespace clang::ast_matchers;
28 
29 namespace clang {
30 namespace tidy {
31 namespace android {
32 
33 /// This module is for Android specific checks.
35 public:
36  void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
37  CheckFactories.registerCheck<CloexecAccept4Check>("android-cloexec-accept4");
38  CheckFactories.registerCheck<CloexecAcceptCheck>("android-cloexec-accept");
39  CheckFactories.registerCheck<CloexecCreatCheck>("android-cloexec-creat");
41  "android-cloexec-epoll-create1");
42  CheckFactories.registerCheck<CloexecEpollCreateCheck>(
43  "android-cloexec-epoll-create");
44  CheckFactories.registerCheck<CloexecDupCheck>("android-cloexec-dup");
45  CheckFactories.registerCheck<CloexecFopenCheck>("android-cloexec-fopen");
46  CheckFactories.registerCheck<CloexecInotifyInitCheck>(
47  "android-cloexec-inotify-init");
49  "android-cloexec-inotify-init1");
50  CheckFactories.registerCheck<CloexecMemfdCreateCheck>(
51  "android-cloexec-memfd-create");
52  CheckFactories.registerCheck<CloexecOpenCheck>("android-cloexec-open");
53  CheckFactories.registerCheck<CloexecSocketCheck>("android-cloexec-socket");
55  "android-comparison-in-temp-failure-retry");
56  }
57 };
58 
59 // Register the AndroidTidyModule using this statically initialized variable.
60 static ClangTidyModuleRegistry::Add<AndroidModule>
61  X("android-module", "Adds Android platform checks.");
62 
63 } // namespace android
64 
65 // This anchor is used to force the linker to link in the generated object file
66 // and thus register the AndroidModule.
67 volatile int AndroidModuleAnchorSource = 0;
68 
69 } // namespace tidy
70 } // namespace clang
creat() is better to be replaced by open().
epoll_create() is better to be replaced by epoll_create1().
Finds code that opens file without using the O_CLOEXEC flag.
void registerCheck(StringRef CheckName)
Registers the CheckType with the name Name.
static ClangTidyModuleRegistry::Add< AndroidModule > X("android-module", "Adds Android platform checks.")
volatile int AndroidModuleAnchorSource
A collection of ClangTidyCheckFactory instances.
Attempts to catch calls to TEMP_FAILURE_RETRY with a top-level comparison operation, like TEMP_FAILURE_RETRY(read(...) != N).
inotify_init() is better to be replaced by inotify_init1().
Finds code that uses epoll_create1() without using the EPOLL_CLOEXEC flag.
A clang-tidy module groups a number of ClangTidyChecks and gives them a prefixed name.
fopen() is suggested to include "e" in their mode string; like "re" would be better than "r"...
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override
Implement this function in order to register all CheckFactories belonging to this module...
Finds code that uses inotify_init1() without using the IN_CLOEXEC flag.
Finds code that uses accept4() without using the SOCK_CLOEXEC flag.
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
accept() is better to be replaced by accept4().
This module is for Android specific checks.
Finds code that uses socket() without using the SOCK_CLOEXEC flag.
Finds code that uses memfd_create() without using the MFD_CLOEXEC flag.
dup() is better to be replaced by fcntl(), which has close-on-exec flag.