10 #include "clang/AST/ASTContext.h" 11 #include "clang/ASTMatchers/ASTMatchFinder.h" 24 Node.getBeginLoc(), Finder->getASTContext().getSourceManager(),
25 HeaderFileExtensions);
30 DefinitionsInHeadersCheck::DefinitionsInHeadersCheck(StringRef
Name,
33 UseHeaderFileExtension(Options.get(
"UseHeaderFileExtension", true)),
34 RawStringHeaderFileExtensions(Options.getLocalOrGlobal(
37 HeaderFileExtensions,
',')) {
40 llvm::errs() <<
"Invalid header file extension: " 41 << RawStringHeaderFileExtensions <<
"\n";
47 Options.
store(Opts,
"UseHeaderFileExtension", UseHeaderFileExtension);
48 Options.
store(Opts,
"HeaderFileExtensions", RawStringHeaderFileExtensions);
54 auto DefinitionMatcher =
55 anyOf(functionDecl(isDefinition(), unless(isDeleted())),
56 varDecl(isDefinition()));
57 if (UseHeaderFileExtension) {
58 Finder->addMatcher(namedDecl(DefinitionMatcher,
59 usesHeaderFileExtension(HeaderFileExtensions))
64 namedDecl(DefinitionMatcher,
65 anyOf(usesHeaderFileExtension(HeaderFileExtensions),
66 unless(isExpansionInMainFile())))
74 if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred())
85 const auto *ND = Result.Nodes.getNodeAs<NamedDecl>(
"name-decl");
87 if (ND->isInvalidDecl())
99 if (!ND->hasExternalFormalLinkage() && !ND->isInAnonymousNamespace())
102 if (
const auto *FD = dyn_cast<FunctionDecl>(ND)) {
107 if (FD->getTemplatedKind() == FunctionDecl::TK_FunctionTemplate)
110 if (FD->isTemplateInstantiation())
114 if (
const auto *
MD = dyn_cast<CXXMethodDecl>(FD)) {
115 const auto *DC =
MD->getDeclContext();
116 while (DC->isRecord()) {
117 if (
const auto *RD = dyn_cast<CXXRecordDecl>(DC)) {
118 if (isa<ClassTemplatePartialSpecializationDecl>(RD))
120 if (RD->getDescribedClassTemplate())
123 DC = DC->getParent();
127 bool IsFullSpec = FD->getTemplateSpecializationKind() != TSK_Undeclared;
128 diag(FD->getLocation(),
129 "%select{function|full function template specialization}0 %1 defined " 130 "in a header file; function definitions in header files can lead to " 133 diag(FD->getLocation(),
"make as 'inline'",
135 << FixItHint::CreateInsertion(FD->getReturnTypeSourceRange().getBegin(),
137 }
else if (
const auto *VD = dyn_cast<VarDecl>(ND)) {
139 if (VD->getDeclContext()->isDependentContext() && VD->isStaticDataMember())
142 if (isTemplateInstantiation(VD->getTemplateSpecializationKind()))
145 if (VD->hasLocalStorage() || VD->isStaticLocal())
151 diag(VD->getLocation(),
152 "variable %0 defined in a header file; " 153 "variable definitions in header files can lead to ODR violations")
bool parseHeaderFileExtensions(StringRef AllHeaderFileExtensions, HeaderFileExtensionsSet &HeaderFileExtensions, char delimiter)
Parses header file extensions from a semicolon-separated list.
bool isExpansionLocInHeaderFile(SourceLocation Loc, const SourceManager &SM, const HeaderFileExtensionsSet &HeaderFileExtensions)
Checks whether expansion location of Loc is in header file.
Base class for all clang-tidy checks.
const LangOptions & getLangOpts() const
Returns the language options from the context.
StringRef defaultHeaderFileExtensions()
Returns recommended default value for the list of header file extensions.
llvm::SmallSet< llvm::StringRef, 5 > HeaderFileExtensionsSet
void store(ClangTidyOptions::OptionMap &Options, StringRef LocalName, StringRef Value) const
Stores an option with the check-local name LocalName with string value Value to Options.
static constexpr llvm::StringLiteral Name
std::map< std::string, std::string > OptionMap
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
static GeneratorRegistry::Add< MDGenerator > MD(MDGenerator::Format, "Generator for MD output.")
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.
llvm::Optional< llvm::Expected< tooling::AtomicChanges > > Result
DiagnosticBuilder diag(SourceLocation Loc, StringRef Description, DiagnosticIDs::Level Level=DiagnosticIDs::Warning)
Add a diagnostic with the check's name.
AST_MATCHER_P(CXXMethodDecl, hasCanonicalDecl, ast_matchers::internal::Matcher< CXXMethodDecl >, InnerMatcher)